Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamo SignIn UI toolbar fixes and tooltip updates #14842

Merged
merged 32 commits into from
Jan 15, 2024

Conversation

zeusongit
Copy link
Contributor

Purpose

[DYN-6536]
[DYN-5867]
[DYN-5868]

This PR fixes:

  • Remove Sign In menu arrow when no submenu item is present.
  • Add a confirmation dialog box on sign out
  • Consistent sign-in and sign-out UX
  • Update Run Preview option tooltip

DynamoSandbox_4GHJYYgPAs

Screenshot 2024-01-12 at 2 39 59 PM

Declarations

Check these if you believe they are true

  • The codebase is in a better state after this PR
  • Is documented according to the standards
  • The level of testing this PR includes is appropriate
  • User facing strings, if any, are extracted into *.resx files
  • All tests pass using the self-service CI.
  • Snapshot of UI changes, if any.
  • Changes to the API follow Semantic Versioning and are documented in the API Changes document.
  • This PR modifies some build requirements and the readme is updated
  • This PR contains no files larger than 50 MB

Release Notes

  • Remove Sign In menu arrow when no submenu item is present.
  • Add a confirmation dialog box on sign out
  • Update Run Preview option tooltip

Reviewers

@DynamoDS/dynamo

Copy link

UI Smoke Tests

Test: success. 2 passed, 0 failed.
TestComplete Test Result
Workflow Run: UI Smoke Tests
Check: UI Smoke Tests - net8.0

@zeusongit
Copy link
Contributor Author

@QilongTang QilongTang added this to the 3.0.2 milestone Jan 15, 2024
@QilongTang QilongTang merged commit b0eb47a into DynamoDS:master Jan 15, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants